fix: persist JWT session in storage so user identity survives token exchange#146
Open
fix: persist JWT session in storage so user identity survives token exchange#146
Conversation
…xchange The session (sub, userinfo) was lost during authorization code → access token exchange because models.Request did not serialize the session. The storage layer then overwrote the stored session with an empty one passed from handleToken. Add SessionData field to models.Request to serialize/deserialize the session. On restore, only populate the session when stored data exists (no fallback to empty session for old data).
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
Contributor
|
I can confirm that this exposes atleast the Testing config: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
models.Requestwas not serializing the fosite session, causing user identity (sub,userinfo) to be lost during authorization code → access token exchange.SessionDatafield tomodels.Requestto persist the session as JSON.kvs.go,sql.go) now restores the session from stored data when available. For old data withoutSessionData, the session remains nil (no fallback to empty session).subanduserinfoclaims survive the full OAuth flow.Type of Change
Related Issues
Related to #143